Re: backform.pgadmin: fix for showing multiple errors for radio control [pgadmin4]

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: backform.pgadmin: fix for showing multiple errors for radio control [pgadmin4]
Date: 2016-02-22 11:37:02
Message-ID: CAG7mmozD4+pZPm3TXEbti33D8VV6Y2Pv=5Oe+uX=3mzFU3AR4A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Feb 11, 2016 at 6:44 PM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA patch for backform.pgadmin.js
>
> *Issue fixed*: Backform was showing same error multiple times (equal to
> no. of radio buttons in radio group) in dialog.
>
Approach for this patch is wrong, we should not change the common
functionality, and check radio button in it.

That's wrong way to do it.

Though - I've checked-in the fix for it by extending the RadioControl
itself.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
> See attached screen shot.
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB <http://www.enterprisedb.com>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-02-22 11:50:36 pgAdmin 4 commit: Adding Numeric control support for Backform.
Previous Message Ashesh Vashi 2016-02-22 11:35:09 pgAdmin 4 commit: Do not need to implement the BackendSupported functio