Re: PATCH: To fix expanding server if server inaccessible (pgAdmin4)

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix expanding server if server inaccessible (pgAdmin4)
Date: 2016-06-02 09:31:36
Message-ID: CAG7mmozBx-XAtgNm=AZ_1c9M-M29DY0eRchG=B1Pv9Ha28wbPQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - all patches are committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Wed, Jun 1, 2016 at 11:04 AM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> On 01-Jun-2016, at 12:03 am, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
> wrote:
>
> On Tue, May 31, 2016 at 11:56 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>> On 31 May 2016, at 19:08, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
>> wrote:
>>
>> On Tue, May 31, 2016 at 8:28 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>>
>>> On Tue, May 31, 2016 at 3:43 PM, Murtuza Zabuawala
>>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>> > Hi,
>>> >
>>> > As advised by Ashesh, I have tried flask 'threaded' options for this
>>> issues
>>> > & it fixed the issue.
>>> >
>>> > PFA patches to fix long load delay when expanding server if server is
>>> > inaccessible.
>>> > (RM#1185).
>>>
>>> That'll only affect users running under Werkzeug. What about Apache?
>>> Is it an issue there?
>>>
>> A while ago - we discussed about the connection management issue, and we
>> decided to write a deployment guide about using pgAdmin 4 as WSGI
>> application under HTTPD using mod_wsgi.
>> And, while configuring Apache, we will need to use the WSGIDaemon option
>> with mod_wsgi, which will allow us to specify the number of threads to be
>> used for request handling at a time.
>>
>> Reference:
>> http://flask.pocoo.org/docs/0.11/deploying/mod_wsgi/#configuring-apache
>>
>>
>> Right, and I wrote that guide - it's in the docs :-)
>>
> :-).
>
> Good - I was thinking - you would ask me to write.. :P
>
>>
>> I just wanted to be sure that this particular issue isn't a problem in
>> such a configuration.
>>
>
> It is not.
>
> --
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
>>
>>
>> --
>> Thanks & Regards,
>>
>> Ashesh Vashi
>>
>>>
>>> > ------
>>> > Additional patches to enhance misc validations in
>>> > menu.js/schema.js/dashboard.js.
>>>
>>> Please detail what these are intended to fix.
>>>
>>>
>>>
> Here, we have added validation checks before accessing object.
> Mostly we get object 'XYZ is undefined' OR 'XYZ Null' errors.
>
> PFA screenshot for example.
>
>
>
>
> > (There are no RM's for these fixes, these are just enhancements)
>>> >
>>> >
>>> > --
>>> > Regards,
>>> > Murtuza Zabuawala
>>> > EnterpriseDB: http://www.enterprisedb.com
>>> > The Enterprise PostgreSQL Company
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>
>>
>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-06-02 09:38:49 pgAdmin 4 commit: Fixes# 1290 - Use qtLiteral with parameterized values
Previous Message Ashesh Vashi 2016-06-02 09:31:26 pgAdmin 4 commit: Check valid DOMElement existance before accessing it