Re: pg_scanner - patch no.1

On Mon, Nov 19, 2012 at 10:57 PM, Vladimir Kokovic <
vladimir(dot)kokovic(at)gmail(dot)com> wrote:

> Hi,
>
> Sorry.
>
No need to say sorry.
We're all trying create a good product and thanks for putting the efforts.

> New diff is now tested with git HEAD repository !
>
- There is no reason, we need two different files of keywords with similar
content.
Please reuse the header - pgadmin/include/parser/keywords.h

When compiled with PostgreSQL 9.0.3, I got this error.
*gcc -c -arch i386 -arch i386 -DSCANNER_VERSION=92 -DPGADMIN_SCANNER
-I./pg_scanners/pg92 -I./include/utils
-I./pg_scanners/pg92/src/backend/parser/92 -I./pg_scanners/pg92/src/include
-Wall -I`/Users/ashesh/Developments/pg//bin/pg_config --includedir`
-I`/Users/ashesh/Developments/pg//bin/pg_config --includedir-server` -o
pg_scanners/pg92/keywords.o pg_scanners/pg92/src/backend/parser/keywords.c*
*In file included from pg_scanners/pg92/src/backend/parser/keywords.c:29:*
*/Users/ashesh/Developments/pg/include/postgresql/server/parser/kwlist.h:97:
error: ‘CREATEDB’ undeclared here (not in a function)*
*/Users/ashesh/Developments/pg/include/postgresql/server/parser/kwlist.h:98:
error: ‘CREATEROLE’ undeclared here (not in a function)*
*/Users/ashesh/Developments/pg/include/postgresql/server/parser/kwlist.h:99:
error: ‘CREATEUSER’ undeclared here (not in a function)*
*/Users/ashesh/Developments/pg/include/postgresql/server/parser/kwlist.h:229:
error: ‘LOGIN_P’ undeclared here (not in a function)*
*/Users/ashesh/Developments/pg/include/postgresql/server/parser/kwlist.h:245:
error: ‘NOCREATEDB’ undeclared here (not in a function)*
*/Users/ashesh/Developments/pg/include/postgresql/server/parser/kwlist.h:246:
error: ‘NOCREATEROLE’ undeclared here (not in a function)*
*/Users/ashesh/Developments/pg/include/postgresql/server/parser/kwlist.h:247:
error: ‘NOCREATEUSER’ undeclared here (not in a function)*
*/Users/ashesh/Developments/pg/include/postgresql/server/parser/kwlist.h:248:
error: ‘NOINHERIT’ undeclared here (not in a function)*
*/Users/ashesh/Developments/pg/include/postgresql/server/parser/kwlist.h:249:
error: ‘NOLOGIN_P’ undeclared here (not in a function)*
*/Users/ashesh/Developments/pg/include/postgresql/server/parser/kwlist.h:251:
error: ‘NOSUPERUSER’ undeclared here (not in a function)*
*/Users/ashesh/Developments/pg/include/postgresql/server/parser/kwlist.h:356:
error: ‘SUPERUSER_P’ undeclared here (not in a function)*
*make[3]: *** [pg_scanners/pg92/keywords.o] Error 1*
*make[2]: *** [all] Error 2*
*make[1]: *** [all-recursive] Error 1*
*make: *** [all] Error 2*

--

Thanks & Regards,

Ashesh Vashi

EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*

>
> root(at)vlD-kuci:/tmp#
> root(at)vlD-kuci:/tmp# cd pgadmin-git/pgadmin3; git apply
> /root/files/pgadmin/unified-diff-move1/pgadmin3-1.diff; cd /tmp
> root(at)vlD-kuci:/tmp#
>
> Best regards
> Vladimir Kokovic
> Belgrade, Serbia, 19.November 2012
>