Re: pgagent job failing to halt on failed step

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgagent job failing to halt on failed step
Date: 2015-12-01 10:16:00
Message-ID: CAG7mmoz=s51E0_ec70b2xswEnWHA6VojPrqi28fC7nn4TFV3Lg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Yes.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Tue, Dec 1, 2015 at 2:52 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> This is what you just committed right Ashesh?
>
> On Tue, Dec 1, 2015 at 5:36 AM, Sanket Mehta
> <sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
> >
> > Hi,
> >
> > There is an issue in current pgagent code as explained below:
> >
> > Issue:
> > In batch mode if user creates a job with multiple job steps then if first
> > jobstep gets executed successfully then even if 2nd step is a failure,
> job
> > will not halt at that point and will complete its execution. which is not
> > the expected result.
> >
> > Analysis:
> > The main reason for this issue is that in batch mode, when first step is
> > executed successfully, flag succeeded will be set to true, but when the
> 2nd
> > step gets failed, its not getting reset to false which is why job does
> not
> > halt at the same instance and continues executing next steps.
> >
> > I have resolved this issue and patch is attached with this mail for
> review.
> > Please do review the patch and let me know in case anything is missing.
> > Regards,
> > Sanket Mehta
> > Sr Software engineer
> > Enterprisedb
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2015-12-02 09:19:10 Re: [pgadmin-support] SSH tunnel key exchange methods
Previous Message Dave Page 2015-12-01 09:22:47 Re: pgagent job failing to halt on failed step