Re: Fixed some issues related to Resource Group

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fixed some issues related to Resource Group
Date: 2014-11-03 05:40:55
Message-ID: CAG7mmoyxTnbJzxi6HZGmj0G_1bcUWock=hFF43duAnRtwh4LVg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Oct 30, 2014 at 8:41 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Ashesh, can you review/commit this please?
>
> Thanks.
>
> On Thu, Oct 30, 2014 at 1:14 PM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave
>>
>> As resource group is a shared object, so it can't be run in a
>> transnational block. With the current implementation if user change the
>> name and any other parameter it will throw an error message as two ALTER
>> statement can't run in a transnational block.
>>
>> I have fixed the issue. I have modified the logic and add one more text
>> box in SQL tab on "Resource Group" dialog as we have in "New Database"
>> dialog.
>>
>> Attached is the patch file of the above fix. Please review it and if it
>> looks good, can you please commit the code.
>>
> Patch looks good to me.
Committed.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246*
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2014-11-03 06:40:24 Re: index only scans are not shown graphically
Previous Message Ashesh Vashi 2014-11-03 04:57:23 pgAdmin III commit: Fix an issue related to RESOURCE GROUP dialog.