Re: PATCH: saving macro after query pasting

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: saving macro after query pasting
Date: 2014-07-16 08:43:57
Message-ID: CAG7mmoyvrN05ogVuUefEmyXyV1jCUKRXa7C6sXzhjvfr8FjwRg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Dave/Dmitriy,

I did not see any patch attached.
Did you forget to attach it?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Wed, Jul 16, 2014 at 1:38 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Adding Ashesh :-)
>
>
>
> On Wed, Jul 16, 2014 at 9:07 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Ashesh - can you look at this ASAP please, and commit if it looks OK?
>>
>>
>> On Sat, Jul 12, 2014 at 12:06 PM, Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>
>> wrote:
>>
>>> Hello.
>>>
>>> Please see this patch. These are changes in the macros manage dialog:
>>> - the "Save" button is enabled after any change in the query window
>>> - RestorePosition() in the constructor
>>> - unnecessary variable appQueryModify has been removed
>>> - changed the condition that checks whether the title and query were
>>> filled (method SetMacro())
>>>
>>> Thank you.
>>>
>>> --
>>> Dmitriy Olshevskiy
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2014-07-16 08:56:17 Re: PATCH: saving macro after query pasting
Previous Message Ashesh Vashi 2014-07-16 08:42:12 Re: PATCH: new feature for Query tool: Favourites injection