From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: saving macro after query pasting |
Date: | 2014-07-19 20:10:33 |
Message-ID: | CAG7mmoys4UCtMfM8=1G5ddRqtLJLOkd_xC5S7G_RAU+0j804BA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Looks good to me.
Checked-in!
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
On Wed, Jul 16, 2014 at 1:37 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Ashesh - can you look at this ASAP please, and commit if it looks OK?
>
>
> On Sat, Jul 12, 2014 at 12:06 PM, Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>
> wrote:
>
>> Hello.
>>
>> Please see this patch. These are changes in the macros manage dialog:
>> - the "Save" button is enabled after any change in the query window
>> - RestorePosition() in the constructor
>> - unnecessary variable appQueryModify has been removed
>> - changed the condition that checks whether the title and query were
>> filled (method SetMacro())
>>
>> Thank you.
>>
>> --
>> Dmitriy Olshevskiy
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2014-07-19 21:11:12 | pgAdmin III commit: Allow quick injectection of favourites by name |
Previous Message | Ashesh Vashi | 2014-07-19 20:10:05 | pgAdmin III commit: Saving of macros after pasting a query in to the bo |