Re: [pgAdmin4][Patch]: Add support for Materialized View & Cancel button on dialog header in Grant Wizard

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Add support for Materialized View & Cancel button on dialog header in Grant Wizard
Date: 2016-05-25 12:11:16
Message-ID: CAG7mmoynXy1saJQq_Zus=POd71jt5kN5w20jWehZOJrgE1mfdg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Wed, May 25, 2016 at 2:06 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi
>
> Please find attached patch for the supported added for following:
> 1. Adds support for Materialized Views in Grant Wizard.
> 2. Modified wizard template defined in wizard.js to add support for cancel
> button in wizard header.
> *Issue: *When the wizard is closed, it should cleanup the Backbone
> Models & destroy the Backbone View used, but it wasn't cleaning up with
> default header cancel button provided by alertifyjs.
>
> Also, Removed acl for view in acls.json as views are also table and acls
> for table is already defined.
>
> Please review.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-05-25 12:14:58 pgAdmin 4 commit: Fixes #1150 - Disconnecting a database action should
Previous Message Ashesh Vashi 2016-05-25 12:11:10 pgAdmin 4 commit: [Grant Wizard] Added support for Materialized View in