Re: Bad string from the translation point of view

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Marek Černocký <marek(at)manet(dot)cz>, Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Bad string from the translation point of view
Date: 2014-11-28 14:13:36
Message-ID: CAG7mmoyav-j03h4T9c3TcmoAzrDEjjuZ5uB-2jBHhko2BV=X5w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, Nov 28, 2014 at 3:48 AM, Marek Černocký <marek(at)manet(dot)cz> wrote:

> The construction:
>
> if (wxMessageBox(_("Are you sure you wish to move objects from ") +
> GetQuotedFullIdentifier() + _(" to ") + rdo.GetTablespace() + _("?"),
> _("Move tablespace?"), wxYES_NO) != wxYES)
> return;
>
> in pgadmin/schema/pgTablespace.cpp is bad from the point of view of
> translation. It should be:
>
> if (wxMessageBox(wxString::Format(_("Are you sure you wish to move
> objects from %s to %s?"), GetQuotedFullIdentifier(),
> rdo.GetTablespace()), _("Move tablespace?"), wxYES_NO) != wxYES)
> return;
>
Agree.

Dave,

Can we consider this as bug?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
>
> Regards
> Marek Černocký
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2014-11-28 18:50:53 pgAdmin III commit: Update czech translation
Previous Message Ashesh Vashi 2014-11-28 12:37:29 Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI