Re: depends.js and sql.js

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: depends.js and sql.js
Date: 2016-03-15 16:01:46
Message-ID: CAG7mmoySsKLqjoOHT2kyi43HjNvEtwqSohTvDTzwqPAkzjc-kQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Mar 15, 2016 at 9:22 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi Ashesh,
>
> Any reason the above files are in static directories? Both have
> strings in them that should be translated.
>
When it was implemented initially, I was not in mood to keep the
translation message in individual file.
And, as it does not have any other dynamic data, we kept it in static
directory.

Then - we added the messages later.
I am thinking to create a common javascript, which can keep translatable
messages in at centre location for tightly couple modules.
We're currently using those type of messages in pgBrowser.messages object.

FYI, I'm not overly sure what needs to be done to move them these days
> - I haven't looked into the require code at all.
>
We need to put the javascript, when there is some dynamic code needs to be
generated, then we should put it in templates, and rest should go in static
directory.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-03-15 16:04:21 Re: depends.js and sql.js
Previous Message Ashesh Vashi 2016-03-15 15:55:19 Re: pgAdmin 4 commit: Resolved an issue related to no proper valid/invalid