Re: fix for RM1210 [pgadmin4]

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: fix for RM1210 [pgadmin4]
Date: 2016-06-03 07:34:04
Message-ID: CAG7mmoyJaOURZDPVAq+gxGzMxQshu-w06N84qKaWF_-ZViB5Fg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, Jun 3, 2016 at 12:59 PM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Issue: For column node it was showing wrong sql in sql tab
>
> <html><head></head><body>-- Column: public.test_qmg.a -- ALTER TABLE
> public.test_qmg DROP COLUMN a; ALTER TABLE public.test_qmg ADD COLUMN a
> integer;</body></html>
>
> Fix: I have changed response to ajax response while returning SQL for
> column node.
>
Hi Harshal,

Can you please introduce a function in pgadmin.utils regarding that, which
set the proper mime-type for this purpose, and make sure - we do use that
for each and every nodes, for sql and modified_sql methods?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
>
>
>
>
>
> --
> *Harshal Dhumal*
> *Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Jun 3, 2016 at 12:52 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Harshal,
>>
>>
>> Can you please describe the issue, and root cause, and how did you fix it?
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>> On Fri, Jun 3, 2016 at 12:48 PM, Harshal Dhumal <
>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch for RM1210 <https://redmine.postgresql.org/issues/1210>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Harshal Dhumal 2016-06-03 07:43:19 Re: fix for RM1210 [pgadmin4]
Previous Message Harshal Dhumal 2016-06-03 07:29:27 Re: fix for RM1210 [pgadmin4]