Re: [pgAdmin4][Patch]: SQL Auto completion feature for Query Tool

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: SQL Auto completion feature for Query Tool
Date: 2016-05-21 10:36:47
Message-ID: CAG7mmoxw8OJ6P=pgOFVT0KOcpi+w+UB98m6o_t3z3kn4GtqKGg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - committed with some minor tweaks.

In order to load a directory as python module, we should have at least
empty __init__.py file exists in that directory.
Also, I've changed the keywords in capital letters.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Thu, May 19, 2016 at 4:54 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Hi All
>
> Today I have added support for multi line and also improve searching
> logic. Please ignore the last patch.
> Attached is the new patch. Please review it and let me know the review
> comments (if any).
>
> On Wed, May 18, 2016 at 8:18 PM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Just to update Multi line support is not there right now.
>>
>> On Wed, May 18, 2016 at 8:09 PM, Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi All
>>>
>>> I have implemented the sql auto complete feature for Query Tool in
>>> pgAdmin4. To achieve this I have analyzed the code of "*pgcli (*http://
>>> pgcli.com/)" and also used some part of the code "(https://github.com/
>>> dbcli/pgcli *)*" with our own modification.
>>>
>>> "pgcli" buffers all the data(databases, tables, functions etc...) at
>>> once while connecting to the database, but we can't do that, so when user
>>> press "*Ctrl+Space*" in the Query Tool we will fetch the data and
>>> display the suggestions accordingly.
>>>
>>> Attached is the patch file. Please review it and let me know the review
>>> comments (if any).
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-05-21 16:45:50 pgAdmin website commit: Make versions.json match reality
Previous Message Ashesh Vashi 2016-05-21 10:35:12 pgAdmin 4 commit: Adding support for autocomplete in the SQL Editor.