From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Allow to skip the feature tests |
Date: | 2017-03-08 10:06:47 |
Message-ID: | CAG7mmoxgGg6YOP0iP+zMf7R_CmTQe89qaA02U7h3ktG1Lastpw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
On Wed, Mar 8, 2017 at 2:54 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Thanks, applied.
>
> On Wed, Mar 8, 2017 at 8:19 AM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave/Team,
>>
>> It is not possible to run the regression testsuite on a machine, where
>> chromium driver is not installed with the current implementation, because -
>> we initialize the selenium webdriver on startup without checking whether it
>> is needed, or not.
>>
>> I have attached the patch to take care of the issue.
>> It skips the webdriver initialization, and other related parameters, if
>> 'feature_tests' is explicitly added in the exclude package list.
>>
>> This will allow us to run the regression-suite using the following
>> command without the need of installing the chromedriver on the host machine.
>> i.e.
>> *python runtests.py --exclude feature_tests*
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-03-08 10:14:29 | pgAdmin 4 commit: Add a Polish translation |
Previous Message | Dave Page | 2017-03-08 09:49:51 | pgAdmin 4 commit: Ensure feature tests are compatible with Python 3.5. |