| From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: debugger.c tries to set log_min_messages, why? |
| Date: | 2014-03-01 14:12:51 |
| Message-ID: | CAG7mmoxQfiYaMNOuPzFDBOyRXPQEU=+_M3ptnpRzh5AEp=7nOg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Please find the patch for the issue.
I have changed the "SET log_min_messages TO fatal" to "SET
client_min_messages TO error" in the global listener connection.
And, removed the same line from the target invoker connection.
On Mon, Feb 10, 2014 at 10:14 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info>wrote:
> On Mon, 2014-02-10 at 21:59 +0530, Ashesh Vashi wrote:
> > On Mon, Feb 10, 2014 at 9:54 PM, Guillaume Lelarge
> > <guillaume(at)lelarge(dot)info>wrote:
> >
> > > On Mon, 2014-02-10 at 21:46 +0530, Ashesh Vashi wrote:
> > > > On Sat, Feb 8, 2014 at 10:49 PM, Guillaume Lelarge
> > > > <guillaume(at)lelarge(dot)info>wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > Just a quick question. If you try to use the debugger, it executes
> a
> > > > > "SET log_min_messages TO fatal", which denies any regular user to
> debug
> > > > > his own functions. And actually, I don't see any reason why it
> should
> > > > > set log_min_messages. If there is, which is it?
> > > > >
> > > > When redesigning the debugger, I did not modify the existing
> connection
> > > > settings without much thoughts.
> > > > After reading this mail, I couldn't agree more with you. It
> shouldn't be
> > > > there.
> > > >
> > >
> > > Good to know. Are you working on this, or should I provide a patch?
> > >
> > I will do it.
> > Thanks
> >
>
> OK, thanks, Ashesh :)
>
>
> --
> Guillaume
> http://blog.guillaume.lelarge.info
> http://www.dalibo.com
>
>
--
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
*http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
| Attachment | Content-Type | Size |
|---|---|---|
| debugger_min_message.patch | application/octet-stream | 897 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas 'ads' Scherbaum | 2014-03-03 10:20:54 | crypto library is not installed |
| Previous Message | Ashesh Vashi | 2014-03-01 14:02:06 | Re: frequent crash in explain analyze window |