Re: PATCH: saving macro after query pasting

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: saving macro after query pasting
Date: 2014-07-16 09:06:35
Message-ID: CAG7mmoxOZNdYsnOKjsDp6CcMg26YpCmuUbT=KsDtpm2MvO9v2A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks.
I will look into it.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Wed, Jul 16, 2014 at 2:26 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> PFA
>
>
> On Wed, Jul 16, 2014 at 9:43 AM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Dave/Dmitriy,
>>
>> I did not see any patch attached.
>> Did you forget to attach it?
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>>
>> On Wed, Jul 16, 2014 at 1:38 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Adding Ashesh :-)
>>>
>>>
>>>
>>> On Wed, Jul 16, 2014 at 9:07 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Ashesh - can you look at this ASAP please, and commit if it looks OK?
>>>>
>>>>
>>>> On Sat, Jul 12, 2014 at 12:06 PM, Dmitriy Olshevskiy <
>>>> olshevskiy87(at)bk(dot)ru> wrote:
>>>>
>>>>> Hello.
>>>>>
>>>>> Please see this patch. These are changes in the macros manage dialog:
>>>>> - the "Save" button is enabled after any change in the query window
>>>>> - RestorePosition() in the constructor
>>>>> - unnecessary variable appQueryModify has been removed
>>>>> - changed the condition that checks whether the title and query were
>>>>> filled (method SetMacro())
>>>>>
>>>>> Thank you.
>>>>>
>>>>> --
>>>>> Dmitriy Olshevskiy
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2014-07-19 20:10:05 pgAdmin III commit: Saving of macros after pasting a query in to the bo
Previous Message Dave Page 2014-07-16 08:56:17 Re: PATCH: saving macro after query pasting