Re: Possible Bug: pgAdmin3 , OSX multi monitor quirk.

On Wed, Sep 9, 2015 at 3:31 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks - the patch looks OK to my eyeballs. Ashesh said he'd take a
> look as well, and (I hope) will get it committed. :-)
>
Patch takes care of saving the pgFrame position only.
There were many other aspect of this problem were not resolved properly.

i.e.
- Saving the position of pgDialog/pgProperties dialogs.
- Restoring an existing stored position in negative for them.

I've checked-in the required changes.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

> On Tue, Sep 8, 2015 at 8:34 AM, Sanket Mehta
> <sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > I have created and attached the patch which will set 0 in case of any
> > negative coordinate for any window.
> > Please do review it and let me know if anything is missing.
> >
> >
> > Regards,
> > Sanket Mehta
> > Sr Software engineer
> > Enterprisedb
> >
> > On Fri, Sep 4, 2015 at 1:20 PM, Sanket Mehta <
> sanket(dot)mehta(at)enterprisedb(dot)com>
> > wrote:
> >>
> >> Sure Dave.
> >>
> >> I will look into it and revert back
> >>
> >> Regards,
> >> Sanket Mehta
> >> Sr Software engineer
> >> Enterprisedb
> >>
> >> On Fri, Sep 4, 2015 at 1:15 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>>
> >>> On Thu, Sep 3, 2015 at 4:48 PM, greenpm <pgreen(at)bottomline(dot)com> wrote:
> >>> > It appears that this is a bug in the way the pgAdmin stores the
> window
> >>> > (or
> >>> > dialog) location to the "pgadmin3 Preferences" file when it exits.
> >>> > Following
> >>> > is a snippet of a typical problematic window location. Notice that
> the
> >>> > Top
> >>> > is a negative number. pgAdmin should never save a negative number. If
> >>> > this
> >>> > file is edited to contain a positive number (I used "Top=240") the
> >>> > window
> >>> > appears correctly.
> >>> >
> >>> >
> >>> > [Properties/Server]
> >>> > Left=2525
> >>> > Top=-51
> >>> > Width=600
> >>> > Height=552
> >>>
> >>> Aside from the sign, does it seem that the value is correct, or just
> >>> one that would work? I've seen this issue on my system, however I have
> >>> multiple monitors of differing sizes and always assumed it was just
> >>> wxWidgets getting the position from the wrong monitor (wx really
> >>> doesn't handle multiple displays well).
> >>>
> >>> Sanket; can you see what would be involved in patching the pgAdmin
> >>> code to ensure we never store a negative coordinate for Window
> >>> position? Not sure if just removing the sign or resetting to zero or
> >>> something would be best - I think we need to test that.
> >>>
> >>> --
> >>> Dave Page
> >>> Blog: http://pgsnake.blogspot.com
> >>> Twitter: @pgsnake
> >>>
> >>> EnterpriseDB UK: http://www.enterprisedb.com
> >>> The Enterprise PostgreSQL Company
> >>
> >>
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>