From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Navnath Gadakh <navnath(dot)gadakh(at)enterprisedb(dot)com>, Dave Page <dave(dot)page(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Kanchan Mohitey <kanchan(dot)mohitey(at)enterprisedb(dot)com> |
Subject: | Re: pgAdmin4: Random failure of FTS test cases due to improper random string creation |
Date: | 2017-08-18 03:54:03 |
Message-ID: | CAG7mmox2BA212SUg54Fgj8ciYikJR6LQ+5VVYj85DBq8+YvcxA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Fri, Aug 11, 2017 at 1:24 PM, Navnath Gadakh <
navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Please find the attached patch for UUID creation issues with test
> objects for FTS configurations, FTS dictionaries and FTS parsers.
> Previously(refer email with subject "Build failed in Jenkins:
> pgadmin4-master-python27 #279" and "Build failed in Jenkins:
> pgadmin4-master-python33 #207"), test cases were randomly failing due to
> repetitions of the test object names.
>
> In the old code we used some part of the string for creating a UUID
> string, but it seems that at some point that created string gets repeated
> and due to which test cases were failing as this was a random behavior, now
> it is fixed.
>
Navnath,
We're still not removing the temporary objects, created by test-cases, in
the tear-down function.
We should have removed them in the tear-down function to fix the issue in
proper way.
Dave - thoughts?
-- Thanks, Ashesh
>
> Thanks.
>
>
>
>
>
> --
> Regards,
> Navnath Gadakh
>
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | pgAdmin 4 Jenkins | 2017-08-18 04:18:42 | Jenkins build is back to normal : pgadmin4-master-python33 #286 |
Previous Message | pgAdmin 4 Jenkins | 2017-08-18 03:52:20 | Build failed in Jenkins: pgadmin4-master-python26 #408 |