From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Dialogues not closing |
Date: | 2016-04-15 08:06:13 |
Message-ID: | CAG7mmow_OwW2YeBT_Br6Tjm_bQMthAxzecvetRq5h8C725wRbA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
On Fri, Apr 15, 2016 at 1:20 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
> On Fri, Apr 15, 2016 at 6:32 AM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> On Fri, Apr 15, 2016 at 2:23 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hey Ashesh,
>>>
>>> We have an issue with dialogues not closing on Save button presses.
>>> One of the team told me yesterday or the day before that it's a
>>> general issue, not one specific to the patch I was reviewing at the
>>> time, which I've been finding seems to be the case.
>>>
>>> Any idea what this issue is?
>>>
>> Sure - I will look into it.
>>
>
> Thanks - please make it a priority; I'm at PG Conf NYC next week and
> expect to be doing lots of demos.
>
Please find the patch for the same.
This also includes some of the cleanup required to solve some of the memory
leak issues.
I was not able to reproduce the issue at my end, but - I've idea of when it
could fail to close the panel, which I have resolved in this patch.
Can you please test it?
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachment | Content-Type | Size |
---|---|---|
dialog_close_n_memory_leak.patch | application/octet-stream | 12.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Harshal Dhumal | 2016-04-15 09:00:24 | Initial Check constraint node patch [Pgadmin4] |
Previous Message | Dave Page | 2016-04-15 07:52:42 | Re: [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool |