Re: [pgAdmin4][Patch]: Node issues under catalogs

On Thu, May 26, 2016 at 10:51 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

>
>
> On Thu, May 26, 2016 at 9:28 AM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Thu, May 26, 2016 at 8:58 AM, Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar <
>>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi
>>>>
>>>> Following are the issues fixed in this patch:
>>>> 1. Nodes not expanding under catalogs
>>>> *Issue: *Check for setting schema was missing. schema should set only
>>>> if node is in create mode.
>>>>
>>>> 2. Error fetching node's properties.
>>>> *Issue: *Node attribute *parent_type* is not set to catalogs.
>>>>
>>>
>>> Please share a separate patch for above fixes.
>>>
>> OK
>>
> PFA patch for above two issues.
>

Thanks - committed (with small tweaks)!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.com/>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> <http://www.linkedin.com/in/asheshvashi>
>>>
>>>>
>>>> 3. Don't show create rule option in table create menu if it is under
>>>> catalog.
>>>>
>>>> 4. Security tab of node should be hidden under catalogs.
>>>> Every node with controls *privilege and security labels* must be under *type:
>>>> group*
>>>> to keep them hide when node is listed under catalogs.
>>>> This code is implemented in backform.pgadmin.js
>>>>
>>>> *For Example:*
>>>>
>>>> *schema:[*{
>>>> id: '*security*', label: '{{ _("Security") }}',
>>>> *type: 'group'*
>>>> },{
>>>> id: 'acl', label: '{{ _('Privileges') }}', *group: '{{
>>>> _('security') }}'*
>>>> },{
>>>> id: 'seclabels', label: '{{ _('Security Labels') }}',
>>>> model: SecurityModel, type: 'collection',
>>>> *group: '{{ _('security') }}'*
>>>> }*]*
>>>>
>>>> Please find attached patch and review.
>>>>
>>>>
>>>> Thanks,
>>>> Surinder Kumar
>>>>
>>>>
>>>> --
>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>
>>>>
>>>
>>
>