| From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM4681] Increase cache control max age for static files |
| Date: | 2019-08-29 05:29:17 |
| Message-ID: | CAG7mmowOhX2SYveYbTgSZY6+F6D6yGEYcnpuxydG14fdUD=QBQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Wed, Aug 28, 2019 at 1:32 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch to increase cache control max age (in http header)
> for static files to improve performance over longer run.
> By default it is 43200 seconds (12 hrs), which means that the static files
> like vendor.js, etc. will be fetched again from server after 12hrs. This is
> not required as these files won't change.
>
> Kindly review.
>
I have done the review, it looks good to me.
I have only concern about - with this change the caching will be done for
at least 1 year. I am still kind of confused, what should be the caching
time?
But - we can go ahead with this change.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aditya Toshniwal | 2019-08-29 05:47:56 | Re: [pgAdmin][RM4681] Increase cache control max age for static files |
| Previous Message | Aditya Toshniwal | 2019-08-28 12:38:44 | Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences |