Re: pgAdmin4 PATCH: Domain Module

On Wed, Mar 23, 2016 at 3:09 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Did you forget to attach the latest patch?
>
She did it in the previous patch only.
She forgot to mention about the help string, which she did in later mail.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
> On Wed, Mar 23, 2016 at 7:27 AM, Khushboo Vashi
> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> > Updated one comment.
> >
> > On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi
> > <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> >>
> >> Hi,
> >>
> >> Please find attached updated patch for the Domains module.
> >>
> >> On Wed, Mar 16, 2016 at 9:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>>
> >>> Hi
> >>>
> >>> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi
> >>> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> >>> > Hi,
> >>> >
> >>> > Please find the updated Domain Module Patch.
> >>> >
> >>> > To test this patch, please apply Backgrid Textarea Cell Patch before
> >>> > this.
> >>>
> >>> Thanks. I believe with the following fixes, we'll be done :-)
> >>>
> >>> - Default values should be auto-quoted when necessary (ie. strings, on
> >>> a text-based domain).
> >>
> >> As per our discussion, this should leave unquoted.
> >
> > And also added a hint to the field stated 'Enter an expression or a
> value.'
> >>
> >>
> >>> - "System Domain?" should be in the General section, between owner and
> >>> comment.
> >>
> >> Done
> >>>
> >>> - The switches should use the same colouring/styling as other objects,
> >>> e.g.
> >>>
> >>> options: {
> >>> 'onText': 'Yes', 'offText': 'No',
> >>> 'onColor': 'success', 'offColor': 'primary',
> >>> 'size': 'small'
> >>> }
> >>
> >> Done
> >>>
> >>> - Please remove the Schema property from the main properties tab (not
> >>> the properties dialogue).
> >>
> >> Done
> >>>
> >>> - No icon is show for Checks on the Dependents tab for a domain.
> >>
> >> Done
> >>>
> >>> - The add button on the Security Labels tab is spelt "Add". Why is
> >>> that? Other instances of this grid use "ADD" which is the default in
> >>> backform.pgadmin.js.
> >>
> >> Done
> >>>
> >>> - Dependencies on domain check constraints are listed as being on a
> >>> "Type" not a "Domain".
> >>
> >> Done
> >>>
> >>> - If adding a domain constraint using the grid on the Domain dialogue,
> >>> I cannot specify "NOT VALID". We need a checkbox for that in a narrow
> >>> columns at the end. Unchecking it for an existing constraint should be
> >>> the equivalent of doing "ALTER DOMAIN ... VALIDATE CONSTRAINT"
> >>
> >> Done
> >>>
> >>> - If I switch the "Don't Validate" switch on a constraint, there are
> >>> leading blank lines in the generated SQL. The same occurs when adding
> >>> a comment to a constraint.
> >>
> >> Done
> >>>
> >>> - I think we need to reverse the meaning of "Don't Validate" and
> >>> rename to match the "Valid?" field that's on the properties list.
> >>> Otherwise it's not clear they're the same thing.
> >>
> >> Done
> >>>
> >>> - s/Not Null/Not Null?/
> >>
> >> Done
> >>>
> >>>
> >>>
> >>> --
> >>> Dave Page
> >>> Blog: http://pgsnake.blogspot.com
> >>> Twitter: @pgsnake
> >>>
> >>> EnterpriseDB UK: http://www.enterprisedb.com
> >>> The Enterprise PostgreSQL Company
> >>
> >>
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>