From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
Cc: | Mehmet Emin KARAKAŞ <emin100(at)gmail(dot)com>, Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PgAgent leap year problem |
Date: | 2020-03-04 06:52:46 |
Message-ID: | CAG7mmow0UvptW972pfHM3yJs+NDLpdv8E9Bw7GGdBOKed=Kokw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Wed, Mar 4, 2020 at 10:53 AM Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:
> Hi Mehmet,
>
> It was a bug in pgAgent. Thank you for sharing the patch. I have reviewed
> and tested, it is working fine.
>
> Dave/Ashesh:- Can we commit this patch ?
>
Mehmet,
Thanks for your patch.
Changes look good except it does not take care of the upgrade scenarios.
Hence - updated the patch for the same.
Neel,
Would you please review the updated patch with the upgrade scenarios?
-- Thanks, Ashesh
>
> Thanks,
> Neel Patel
>
> On Mon, Mar 2, 2020 at 5:26 PM Mehmet Emin KARAKAŞ <emin100(at)gmail(dot)com>
> wrote:
>
>> Hi,
>>
>> Scheduled tasks set as the last day of February this year did not work.
>> In your schedule function have a small bug. Leap year function get year
>> parameter, but your code is sending day as a parameter. Fixing patch
>> attached in this mail.
>>
>> Best Regards...
>>
>> --
>> MEHMET EMİN KARAKAŞ
>> PostgreSQL DBA
>>
>> Turksat Satellite Communication and Cable TV Operations
>> Konya Yolu 40. Km. 06839 Golbasi / ANKARA - TÜRKİYE
>> Tel : +90 312 615 32 73
>> Faks : +90 312 615 32 77
>>
>
Attachment | Content-Type | Size |
---|---|---|
pgagent_leap_year.patch | application/octet-stream | 49.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Neel Patel | 2020-03-04 07:06:20 | Re: PgAgent leap year problem |
Previous Message | Neel Patel | 2020-03-04 05:23:36 | Re: PgAgent leap year problem |