Re: Patch: Added select2cell editor for backgrid [pgAdmin4]

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch: Added select2cell editor for backgrid [pgAdmin4]
Date: 2016-04-01 09:38:30
Message-ID: CAG7mmow0LAPVzyHFo-osO-=-sz_n01Bcc=19=XcxZYRfnogHEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Mar 31, 2016 at 12:27 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> We have added Select2Cell Editor for backgrid, eariler as it was not
> present & causing issue in rendering in subnode control.
>
Looks good to me, but - have some feedback.
1. Can you please mention - why do we need 'openOnEnter: false' in select2
options?
2. There is a difference between UI, when rendered from the editor, and
from the Select2Cell. (I can see padding, when the Cell is rendered, but -
not when editor is rendered.)

Can you please fix this two?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-04-01 09:47:48 pgAdmin 4 commit: Updated the template for the NodeAjaxOptionsControl,
Previous Message Ashesh Vashi 2016-04-01 09:29:52 Re: [pgAdmin4][Patch]: Backgrid StringDepsCell