| From: | Yurii Rashkovskii <yrashk(at)omnigres(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrei Lepikhov <lepihov(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add Postgres module info |
| Date: | 2025-03-27 13:38:43 |
| Message-ID: | CAG=VW14rW63X=rqUS1yxLqZJeb_R+oRGdL5ZuF1mRDOMaSmzvg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 26, 2025 at 8:17 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Yurii Rashkovskii <yrashk(at)omnigres(dot)com> writes:
> >> Can you propose a specific change to clean it up? I wanted to write
> >> just "PG_MODULE_MAGIC_DATA()", but I'm not sure that's valid C either.
>
> > I was thinking about passing `.name = NULL, .version = NULL` instead of
> > `0`—do you have any reservations about this?
>
> If we're going that way, I'd minimize it to just ".name = NULL".
>
Would something like this work?
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-PG_MODULE_MAGIC_DATA-0-mixes-designated-and-non-desi.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-03-27 13:40:16 | Re: Remove vardata parameters from eqjoinsel_inner |
| Previous Message | Amul Sul | 2025-03-27 13:36:52 | Re: NOT ENFORCED constraint feature |