Error when editing char(n)[] cells

From: Nick Barnes <nickbarnes01(at)gmail(dot)com>
To: pgadmin-hackers(at)lists(dot)postgresql(dot)org
Subject: Error when editing char(n)[] cells
Date: 2020-01-21 13:25:06
Message-ID: CAG+WGGm+EfRUXekepvyaa+ngiNMQhNTO_5_vaWk1s3c1BKAZrA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

In the "View/Edit Data" grid, editing a char(n)[] or varchar(n)[] cell
triggers a psycopg error: "argument formats can't be mixed". This seems to
be the same issue reported in #4410
<https://redmine.postgresql.org/issues/4410>.

Looks like the cause is a format() template which is using "%s" instead of
"{}", leaving a literal "%s" in the generated SQL. Patch attached.

Cheers,
Nick

Attachment Content-Type Size
0001-Fix-invalid-format-specifiers.-Fixes-4410.patch application/octet-stream 1019 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2020-01-22 12:15:53 [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified
Previous Message Ganesh Jaybhay 2020-01-21 12:58:49 Re: [pgAdmin4][RM#5107] Add tab navigation for buttons in file manager dialogue