Re: Fix a typo in README.dependencies

From: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: atorikoshi <torikoshi_atsushi_z2(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix a typo in README.dependencies
Date: 2017-06-23 06:37:44
Message-ID: CAFjFpRfHGDA5jiq67U7Stx2cbAhJDz7C2pkBM+q1zhMTNGYOng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 23, 2017 at 2:58 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Ashutosh Bapat wrote:
>> On Mon, Jun 5, 2017 at 8:22 AM, atorikoshi
>> <torikoshi_atsushi_z2(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> > Hi,
>> >
>> > I found below formula to compute selectivities, but
>> > I think the last Probability 'P(b=?)' should be 'P(c=?)'.
>> >
>> >> P(a=?,b=?,c=?) = P(a=?,b=?) * (d + (1-d)*P(b=?))
>> >
>> >
>> > Attached patch fixes it, and it also adds some spaces
>> > following another formula which is on line 86 and
>> > computes P(a=?, b=?).
>>
>> Agree. Also using "d" for "degree of functional dependence (b=>c) as
>> well is confusing. We are already using "d" for "degree of functional
>> dependence (a=>b). Here' patch to use "d'" instead of "d".
>
> Since the surrounding text uses single quotes to talk about each letter,
> I thought it was better to use a new letter (e) so that we don't require
> the "prime" notation, which would end up being either inconsistent,
> confusing, stupid-looking, or combinations thereof.

Makes sense.

>
> Also, your proposed text had a slight mistake: it's not (b=>c) that
> d' is for, but (a,b=>c).

Sorry for that.

>
> Pushed with those corrections.

Thanks.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message atorikoshi 2017-06-23 06:37:52 Re: Fix a typo in README.dependencies
Previous Message Michael Paquier 2017-06-23 06:31:04 Re: Setting pd_lower in GIN metapage