Re: Postgres_fdw join pushdown - wrong results with whole-row reference

On Fri, Jul 1, 2016 at 7:45 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Tue, Jun 28, 2016 at 8:20 AM, Ashutosh Bapat
> <ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> >> > postgres_fdw resets the search path to pg_catalog while opening
> >> > connection
> >> > to the server. The reason behind this is explained in deparse.c
> >> >
> >> > * We assume that the remote session's search_path is exactly
> >> > "pg_catalog",
> >> > * and thus we need schema-qualify all and only names outside
> >> > pg_catalog.
> >>
> >> Hmm. OK, should we revert the schema-qualification part of that
> >> commit, or just leave it alone?
> >
> > If we leave that code as is, someone who wants to add similar code later
> > would get confused or will be tempted to create more instances of
> > schema-qualification. I think we should revert the schema qualification.
>
> OK, done.
>

Thanks.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company