| From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
|---|---|
| To: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type |
| Date: | 2018-04-26 13:33:49 |
| Message-ID: | CAFjFpRdG4QrYhnpKJvvJhp6ThrfUm9Bej1mk5TqaA1n6Bx5TiQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 26, 2018 at 9:04 AM, Haribabu Kommi
<kommi(dot)haribabu(at)gmail(dot)com> wrote:
> The jitflags in the PlannedStmt structure of type "int", but in _out and
> _read functions it is treated as of "bool" type.
>
> WRITE_BOOL_FIELD(jitFlags);
> READ_BOOL_FIELD(jitFlags);
>
> I am thinking of it is a copy paste mistake as the other members around the
> initflags are of "bool" type or is there any specific reason to treat as
> "bool" type?
No, I don't see any. Here's patch for the same.
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
| Attachment | Content-Type | Size |
|---|---|---|
| Use-READ-WRITE_INT_FIELD-macro-for-jitFlags.patch | text/x-patch | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-04-26 13:38:00 | Re: minor fix for acquire_inherited_sample_rows |
| Previous Message | Ashutosh Bapat | 2018-04-26 13:02:35 | Re: WIP: a way forward on bootstrap data |