Re: Thinko/typo in ExecSimpleRelationInsert

From: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Thinko/typo in ExecSimpleRelationInsert
Date: 2018-06-26 11:03:52
Message-ID: CAFjFpRdA6j6vfBNxrDPtHotyo2+zY=odRZWENoH_7Zs6h2pJWQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Looks like we need similar adjustment in ExecSimpleRelationUpdate() as
well. Updated the patch.

On Tue, Jun 26, 2018 at 3:12 PM, Ashutosh Bapat
<ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> Hi,
> There seems to be a thinko/typo in ExecSimpleRelationInsert(). A tuple
> can never store a slot, but a comment in that function says so. Tried
> to fix it in the patch attached.
>
> --
> Best Wishes,
> Ashutosh Bapat
> EnterpriseDB Corporation
> The Postgres Database Company

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

Attachment Content-Type Size
0002-Fix-a-thinko-typo-in-ExecSimpleRelationInsert-Update.patch text/x-patch 1.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-06-26 11:19:42 Re: Small fixes about backup history file in doc and pg_standby
Previous Message Masahiko Sawada 2018-06-26 10:45:23 Re: [HACKERS] GUC for cleanup indexes threshold.