| From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | amul sul <sulamul(at)gmail(dot)com>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, David Steele <david(at)pgmasters(dot)net>, Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [POC] hash partitioning |
| Date: | 2017-05-16 03:45:43 |
| Message-ID: | CAFjFpRcoxbJ4_LwzMXg2+OiU0+GacXVCQewqqLRrhmNoG_7-kA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 15, 2017 at 9:13 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, May 15, 2017 at 6:57 AM, amul sul <sulamul(at)gmail(dot)com> wrote:
>>> Collation is only relevant for ordering, not equality. Since hash
>>> opclasses provide only equality, not ordering, it's not relevant here.
>>> I'm not sure whether we should error out if it's specified or just
>>> silently ignore it. Maybe an ERROR is a good idea? But not sure.
>>>
>> IMHO, we could simply have a WARNING, and ignore collation, thoughts?
>>
>> Updated patches attached.
>
> I think that WARNING is rarely a good compromise between ERROR and
> nothing. I think we should just decide whether this is legal (and
> then allow it without a WARNING) or not legal (and then ERROR).
> Telling the user that it's allowed but we don't like it doesn't really
> help much.
+1. We should throw an error and add a line in documentation that
collation should not be specified for hash partitioned table.
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2017-05-16 03:50:22 | Re: Duplicate usage of tablespace location? |
| Previous Message | Tom Lane | 2017-05-16 03:29:23 | Re: src/test/ssl/t/001_ssltests.pl should not tromp on file permissions |