Re: proposal: function parse_ident

Hi

2016-01-23 16:36 GMT+01:00 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:

> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> > On Sat, Jan 23, 2016 at 1:25 AM, Marko Tiikkaja <marko(at)joh(dot)to> wrote:
> > + errmsg("identifier contains disallowed chars"),
> > + errdetail("string \"%s\" is not valid identifier",
> > + text_to_cstring(qualname))));
> > Perhaps, "identifier contains not allowed character" is better?
>
> "disallowed" reads better to me. I agree with expanding "chars" to
> "characters" though. Also, the errdetail is conveying no actual extra
> detail AFAICS. I'd go with something like
>
> errmsg("identifier contains disallowed characters: \"%s\"",
> text_to_cstring(qualname)));
>
> regards, tom lane
>
>
>
>
rebased, messages changes per Tom's proposal

Regards

Pavel

>
>
>
>
>
> The errdeta
>
> regards, tom lane
>
>
>
>
> > --
> > Michael
>
>
> > --
> > Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgsql-hackers
>