| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: review: Built-in binning functions |
| Date: | 2014-06-27 06:33:38 |
| Message-ID: | CAFj8pRDorixkA77EnWPUZoqcCE9vLoEMjdnXQyy7R3nAb6yeEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
I recheck this patch
1. applied cleanly and compilation was without warnings and errors
2. all tests was passed ok
3. documentation was rebuild without issues
4. I don't see any issue in code quality - it is well commented, well
formatted, with regress tests
It is ready for commit
Regards
Pavel
2014-06-26 22:43 GMT+02:00 Petr Jelinek <petr(at)2ndquadrant(dot)com>:
> Here is v2,
>
> with fixed documentation and numeric version of the implementation.
>
>
> --
> Petr Jelinek http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vik Fearing | 2014-06-27 06:49:25 | Re: ALTER SYSTEM RESET? |
| Previous Message | Michael Paquier | 2014-06-27 06:12:05 | Re: WAL format and API changes (9.5) |