From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_dump quietly ignore missing tables - is it bug? |
Date: | 2015-08-23 13:47:48 |
Message-ID: | CAFj8pRDmzdSCkzK5uYiwTT1MeAZ37MzvVWm+zSZz7hrZiAJ-SA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
2015-08-22 0:09 GMT+02:00 Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, failed
> Spec compliant: not tested
> Documentation: not tested
>
> The feature doesn't seem to work:
> pg_dump -t t -t 'ii*' --strict-names
> pg_dump: unrecognized option `--strict-names'
> Try "pg_dump --help" for more information.
> decibel(at)decina:[16:58]~/git/postgres/i
> (pg_dump-strict-names-7.patch=)$bin/p
>
sorry - there was wrong strict-mode
fixed
>
> The documentation could use some improvements.
>
> + <para>
> + Require that table and/or schema match at least one entity each.
> + Without any entity in the database to be dumped, an error message
> + is printed and dump is aborted.
> + </para>
>
> Would be clearer as
>
> Require that each schema (-n / --schema) and table (-t / --table)
> qualifier match at least one schema/table in the database to be dumped.
> Note that if none of the schema/table qualifiers find matches pg_dump will
> generate an error even without --strict-names.
>
> + <para>
> + This option has no effect on the exclude table and schema
> patterns
> + (and also <option>--exclude-table-data</>): not matching any
> entities
> + isn't considered an error.
>
> Rewrite:
> This option has no effect on -N/--exclude-schema, -T/--exclude_table or
> --exclude-table-date. An exclude pattern failing to match any objects is
> not considered an error.
>
>
fixed
Regards
Pavel
> The new status of this patch is: Waiting on Author
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
Attachment | Content-Type | Size |
---|---|---|
pg_dump-strict-names-8.patch | text/x-patch | 14.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2015-08-23 15:27:18 | Re: PATCH: numeric timestamp in log_line_prefix |
Previous Message | Michael Paquier | 2015-08-23 13:34:35 | Re: New functions |