From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Marko Tiikkaja <marko(at)joh(dot)to> |
Subject: | Re: plpgsql.warn_shadow |
Date: | 2014-01-26 22:44:01 |
Message-ID: | CAFj8pRDK1jK+fC=osj+apGo3=L-WRKFkLS-Fv1L3CCCgRc=wEg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dne 26. 1. 2014 23:24 "Simon Riggs" <simon(at)2ndquadrant(dot)com> napsal(a):
>
> On 26 January 2014 15:53, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> >
> >
> >
> > 2014-01-26 Florian Pflug <fgp(at)phlo(dot)org>
> >
> >> On Jan26, 2014, at 10:19 , Simon Riggs <simon(at)2ndQuadrant(dot)com> wrote:
> >> > Also, having
> >> > plpgsql.warnings_as_errors = off (default) | on
> >> > makes sense and should be included in 9.4
> >>
> >> I still think this is a bad idea, for the same reasons I don't like
> >> consistent_into (discussed in a separate thread).
> >>
> >> But these objections would go away if restricted this to function
> >> creation time only. So even with warnings_as_errors=on, you
> >> could still *call* a function that produces a warning, but not
> >> *create* one.
> >
> >
> > +1 behave - and please, better name
>
> +1 to that.
>
> I guess I only saw that way of working because I was thinking of it as
> a "compiler warning".
>
> So perhaps we should call it
> plpgsql.compiler_warnings_as_errors
>
> to make that behaviour more clear.
>
> plpgsql.error_on_create_warnings
I have a problém with joining word error and warning together.
Some like stop_on_compilation_warning or strict_compiler sound me more
logical
Regards
Pavel
>
> --
> Simon Riggs http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2014-01-26 23:18:22 | Re: plpgsql.warn_shadow |
Previous Message | Andrew Dunstan | 2014-01-26 22:42:20 | jsonb and nested hstore |