Re: Doing better at HINTing an appropriate column within errorMissingColumn()

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Doing better at HINTing an appropriate column within errorMissingColumn()
Date: 2014-03-28 08:25:09
Message-ID: CAFj8pRDH7vqVpDP4GWw9CNS6sBrZjnKFgGwBjWchxMSxqV89Hg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2014-03-28 9:22 GMT+01:00 Peter Geoghegan <pg(at)heroku(dot)com>:

> On Fri, Mar 28, 2014 at 1:00 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
> > I see only one risk - it can do some slowdown of exception processing.
>
> I think it's unlikely that you'd see ERRCODE_UNDEFINED_COLUMN in
> procedural code like that in practice. In any case it's worth noting
> that I continually pass back a "max" to the Levenshtein distance
> implementation, which is the current shortest distance observed. The
> implementation is therefore not obliged to exhaustively find a
> distance that is already known to be of no use. See commit 604ab0.
>

if it is related to ERRCODE_UNDEFINED_COLUMN then it should be ok (from
performance perspective)

but second issue can be usage from plpgsql - where is mix SQL identifiers
and plpgsql variables.

Pavel

>
>
> --
> Peter Geoghegan
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-03-28 08:31:15 Re: trgm regex index peculiarity
Previous Message Peter Geoghegan 2014-03-28 08:22:09 Re: Doing better at HINTing an appropriate column within errorMissingColumn()