Re: [PROPOSAL] Shared Ispell dictionaries

2017-12-26 17:55 GMT+01:00 Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>:

> Arthur Zakirov wrote:
>
> > Implementation
> > --------------
> >
> > It is necessary to change all structures related with IspellDict:
> > SPNode, AffixNode, AFFIX, CMPDAffix, IspellDict itself. They all
> > shouldn't use pointers for this reason. Others are used only during
> > dictionary building.
>
> So what are you going to use instead?
>
> > It would be good to store in a shared memory StopList struct too.
>
> Sure (probably a separate patch though).
>
> > All fields of IspellDict struct, which are used only during dictionary
> > building, will be move into new IspellDictBuild to decrease needed
> > shared memory size. And they are going to be released by buildCxt.
> >
> > Each dictionary will be stored in its own dsm segment.
>
> All that sounds reasonable.
>
> > The patch will be ready and added into the 2018-03 commitfest.
>
> So this will be a large patch not submitted to 2018-01? Depending on
> size/complexity I'm not sure it's OK to submit 2018-03 only -- it may be
> too late.
>

Tomas had some workable patches related to this topic

Regards

Pavel

>
> --
> Álvaro Herrera https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
>