Re: Deparsing rewritten query

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Gilles Darold <gilles(at)darold(dot)net>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Deparsing rewritten query
Date: 2022-01-31 17:46:37
Message-ID: CAFj8pRCzdbPJkUOP6e-mci=Vo91FqBOLvYsiJWAaVkEXGyJb5Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

po 31. 1. 2022 v 15:37 odesílatel Gilles Darold <gilles(at)darold(dot)net> napsal:

> Le 28/06/2021 à 18:41, Julien Rouhaud a écrit :
> > Thanks for the feedback Gilles!
> >
> > On Mon, Jun 28, 2021 at 04:06:54PM +0200, Gilles Darold wrote:
> >> If we could at least call get_query_def()through an extension if we
> didn't
> >> have a functionit would be ideal for DBAs.I agree this is unusual but
> when
> >> it does happen to you being able to call get_query_def () helps a lot.
> > Since at least 2 other persons seems to be interested in that feature, I
> can
> > take care of writing and maintaining such an extension, provided that the
> > required infrastructure is available in core.
> >
> > PFA v2 of the patch which only adds the required alias and expose
> > get_query_def().
>

I checked the last patch. I think it is almost trivial. I miss just
comment, why this alias is necessary

+ if (!rte->alias)
+ rte->alias = makeAlias(get_rel_name(rte->relid), NULL);

Regards

Pavel

>
> Thanks a lot Julien, such facilities are really helpful for DBAs and
> make the difference with other RDBMS. I don't think that this feature
> exists else where.
>
>
> --
> Gilles Darold
> http://www.darold.net/
>
>
>
>
>
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-01-31 18:02:05 Re: plperl on windows
Previous Message Mark Dilger 2022-01-31 17:29:40 Re: CREATEROLE and role ownership hierarchies