Re: On login trigger: take three

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Greg Nancarrow <gregn4422(at)gmail(dot)com>
Cc: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: On login trigger: take three
Date: 2020-12-09 12:24:48
Message-ID: CAFj8pRCkROV76Oc8AwsYNGM2uEEJUMLQd7kSxrvrnwh=pHtb2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

st 9. 12. 2020 v 13:17 odesílatel Greg Nancarrow <gregn4422(at)gmail(dot)com>
napsal:

> On Tue, Dec 8, 2020 at 3:26 PM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
> >
> >
> > There are two maybe generic questions?
> >
> > 1. Maybe we can introduce more generic GUC for all event triggers like
> disable_event_triggers? This GUC can be checked only by the database owner
> or super user. It can be an alternative ALTER TABLE DISABLE TRIGGER ALL. It
> can be protection against necessity to restart to single mode to repair the
> event trigger. I think so more generic solution is better than special
> disable_client_connection_trigger GUC.
> >
> > 2. I have no objection against client_connection. It is probably better
> for the mentioned purpose - possibility to block connection to database.
> Can be interesting, and I am not sure how much work it is to introduce the
> second event - session_start. This event should be started after connecting
> - so the exception there doesn't block connect, and should be started also
> after the new statement "DISCARD SESSION", that will be started
> automatically after DISCARD ALL. This feature should not be implemented in
> first step, but it can be a plan for support pooled connections
> >
>

PGC_SU_BACKEND is too strong, there should be PGC_BACKEND if this option
can be used by database owner

Pavel

> I've created a separate patch to address question (1), rather than
> include it in the main patch, which I've adjusted accordingly. I'll
> leave question (2) until another time, as you suggest.
> See the attached patches.
>
> Regards,
> Greg Nancarrow
> Fujitsu Australia
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2020-12-09 12:34:26 Re: On login trigger: take three
Previous Message Dilip Kumar 2020-12-09 12:19:03 Re: Parallel INSERT (INTO ... SELECT ...)