| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Christoph Berg <myon(at)debian(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: compute_query_id and pg_stat_statements |
| Date: | 2021-05-12 09:42:12 |
| Message-ID: | CAFj8pRCfxtRCoT10wyDAGq6cuW3oVfEJ_JUjEGW_jBs=tpPYnA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
st 12. 5. 2021 v 11:39 odesílatel Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
napsal:
> At Wed, 12 May 2021 17:30:26 +0800, Julien Rouhaud <rjuju123(at)gmail(dot)com>
> wrote in
> > On Wed, May 12, 2021 at 10:57:25AM +0200, Pavel Stehule wrote:
> > >
> > > My second proposal can work for your example too. pg_stat_statements
> have
> > > to require any active queryid computing. And when it is not available,
> then
> > > the exception should be raised.
> > >
> > > The custom queryid can return null, and still the queryid will be
> computed.
> > > Maybe the warning can be enough. Just, if somebody use
> pg_stat_statements
> > > function, then enforce the check if queryid is computed
> (compute_query_id
> > > is true || some hook is not null), and if not then raise a warning.
> >
> > Ah I'm sorry I misunderstood your proposal. Yes, definitely adding a
> warning
> > or an error when executing pg_stat_statements() SRF would help, that's a
> great
> > idea!
> >
> > I'll wait a bit in case someone has any objection, and if not send an
> updated
> > patch!
>
> Isn't there a case where pg_stat_statements uses an alternative
> query-id provider?
>
this check just can check if there is "any" query-id provider. In this
context is not important if it is buildin or external
> regards.
>
> --
> Kyotaro Horiguchi
> NTT Open Source Software Center
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-05-12 09:42:31 | Re: compute_query_id and pg_stat_statements |
| Previous Message | Kyotaro Horiguchi | 2021-05-12 09:39:27 | Re: compute_query_id and pg_stat_statements |