Re: xmlserialize bug - extra empty row at the end

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: xmlserialize bug - extra empty row at the end
Date: 2023-04-23 14:50:41
Message-ID: CAFj8pRC_7hH9McSbXnmHhZxdDjVDpJ6wF+5pxxESBEdA2RHXHA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

ne 23. 4. 2023 v 16:48 odesílatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:

> Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> writes:
> > On 23.04.23 07:31, Pavel Stehule wrote:
> >> Looks so there is an extra empty row.
>
> > Good catch! It looks like it comes directly from libxml2.
>
> Is it really a bug? If libxml2 itself is putting in that newline,
> I'm not sure we should take it on ourselves to strip it.
>

Maybe It is not a bug, but it can be messy. "json_pretty" doesn't do it.

>
> > I'll do some digging to see if there is a good way to get rid of this
> > newline or if we need to chose a different dump function.
>
> If we do want to strip it, I'd just add a couple lines of code
> to delete any trailing newlines at the end of the process.
> Compare, eg, pchomp().
>

yes

Pavel

>
> regards, tom lane
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-04-23 14:52:27 Re: xmlserialize bug - extra empty row at the end
Previous Message Pavel Stehule 2023-04-23 14:48:37 Re: xmlserialize bug - extra empty row at the end