| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: why pg_size_pretty is volatile? |
| Date: | 2016-01-26 06:00:43 |
| Message-ID: | CAFj8pRCWN+Nbja9YYSc-8SzOPze5M1tsTJEH-=GWi=So7+gz6A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2016-01-26 2:00 GMT+01:00 Michael Paquier <michael(dot)paquier(at)gmail(dot)com>:
> On Tue, Jan 26, 2016 at 5:35 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
> > Vitaly Burovoy pointed on bug in my patch - a pg_size_bytes was VOLATILE
> > function. It is copy/paste bug - I used pg_size_pretty definition, so the
> > question is: why pg_size_pretty is volatile? It should be immutable too.
>
> +1. This function relies only on the input of its argument to generate a
> result.
>
attached patch
all tests passed
Regards
Pavel
> --
> Michael
>
| Attachment | Content-Type | Size |
|---|---|---|
| pg_size_pretty-immutable.patch | text/x-patch | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Piotr Stefaniak | 2016-01-26 06:26:16 | Re: Releasing in September |
| Previous Message | Vitaly Burovoy | 2016-01-26 05:25:34 | Re: custom function for converting human readable sizes to bytes |