Re: proposal: better support for debugging of overloaded functions

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: better support for debugging of overloaded functions
Date: 2011-11-24 16:44:16
Message-ID: CAFj8pRCWFhtYBHXzGFvz6yznzRog2RFT_K5PXc0cTP9PjDmm+w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello

2011/11/21 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Sun, Nov 20, 2011 at 6:16 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> Is possible to add GUC variable plpgsql.log_function_signature (maybe
>> just log_function_signature (for all PL))? I am not sure about GUC
>> name.
>>
>> When this variable is true, then CONTEXT line will contain a qualified
>> function's signature instead function name
>
> Sure, but why?  If it's possible to do that, I think we should just do
> it always.  It might be a net reduction in readability for people who
> don't use overloading but do have functions with very long names and
> lots and lots of arguments, but even if you think that's good design,
> I think the general principle that an error message should uniquely
> identify the object responsible for the error ought to take
> precedence.

I inclined so this is good solution

there is a VIP patch

patch is relative long, but almost all are changes in regress tests.
Changes in plpgsql are 5 lines

Regards

Pavel

>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
fn_signature.diff text/x-patch 41.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-11-24 16:47:16 Re: Making TEXT NUL-transparent
Previous Message Theo Schlossnagle 2011-11-24 16:33:31 Re: logging in high performance systems.