Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013/11/11 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>

>
>
>
> 2013/11/11 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
>
>> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
>> > Turns out that's bogus - ALTER TABLE has two levels of NOT EXISTS.
>>
>> > Maybe we should just do the same for DROP TRIGGER?
>>
>> > DROP TRIGGER [ IF EXISTS ] name ON table_name [ IF EXISTS ] [ CASCADE |
>> RESTRICT ]
>>
>
This syntax is not consistent with other IF EXISTS.

should be (IF EXISTS is before name always)

DROP TRIGGER [ IF EXISTS ] name ON [ IF EXISTS ] table_name [ CASCADE |
RESTRICT ]

What do you think about?

Regards

Pavel

>
>> Works for me.
>>
>
> for me too
>
> tomorrow I'll prepare patch
>
> Regards
>
> Pavel
>
>
>>
>> regards, tom lane
>>
>>
>> --
>> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgsql-hackers
>>
>
>