| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, rafia(dot)sabih(at)enterprisedb(dot)com, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgbench - allow to store select results into variables |
| Date: | 2017-10-25 09:55:18 |
| Message-ID: | CAFj8pRCGNRALRm6r2n-9iZQENJ92J3Hm=17mwXKeERXuNuAq7g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
2017-10-20 18:37 GMT+02:00 Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>:
>
> Here is a v12.
>>
>
> Here is a v13, which is just a rebase after the documentation xml-ization.
>
I am looking to this patch.
Not sure if "cset" is best name - maybe "eset" .. like embeded set?
The code of append_sql_command is not too readable and is not enough
commented.
I don't understand why you pass a param compounds to append_sql_command,
when this value is stored in my_command->compound from create_sql_command?
Or maybe some unhappy field or variable names was chosen.
Regards
Pavel
>
> --
> Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anthony Bykov | 2017-10-25 11:51:00 | Jsonb transform for pl/python |
| Previous Message | Beena Emerson | 2017-10-25 09:18:10 | Re: path toward faster partition pruning |