Re: ToDo: show size of partitioned table

st 13. 3. 2019 v 8:02 odesílatel Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
napsal:

> On 2019/02/22 1:41, Pavel Stehule wrote:
> > čt 21. 2. 2019 v 0:56 odesílatel Justin Pryzby <pryzby(at)telsasoft(dot)com>
> > napsal:
> >
> >> On Sat, Feb 16, 2019 at 10:52:35PM +0100, Pavel Stehule wrote:
> >>> I like your changes. I merged all - updated patch is attached
> >>
> >> I applied and tested your v10 patch.
> >>
> >> Find attached some light modifications.
> >>
> >
> > I have not any objection - I cannot to evaluate. It is question for some
> > native speaker.
>
> Not a native speaker either, but I like Justin's changes. Although I
> noticed that he missed changing one sentence to look like other similar
> sentences.
>
> What Justin did:
>
> - indexes) and associated description are also displayed.
> + indexes) is displayed, as is the relation's description.
> </para>
>
> What I think he meant to do:
>
> - indexes) and associated description are also displayed.
> + indexes) is also displayed, along with the associated description.
> </para>
>
>
> > I am not sure if we use labels in form "some: detail" somewhere.
>
> I haven't seen column names like that either. How about:
>
> - gettext_noop("Direct partitions size"));
> + gettext_noop("Leaf partition size"));
>
> - gettext_noop("Total partitions size"));
> + gettext_noop("Total size"));
>
> - gettext_noop("Partitions size"));
> + gettext_noop("Total size"));
>

+1

Pavel

> I've attached v11 of the patch, which merges most of Justin's changes and
> some of my own on top -- documentation and partition size column names.
>
> Thanks,
> Amit
>