Re: Poll: are people okay with function/operator table redesign?

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Steven Pousty <steve(dot)pousty(at)gmail(dot)com>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, Pierre Giraud <pierre(dot)giraud(at)dalibo(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Poll: are people okay with function/operator table redesign?
Date: 2020-04-19 03:40:01
Message-ID: CAFj8pRC4LS-a+wgJ6LgKKekQ+ZTaOcO24SVNHotOjtni-1Dxtw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

so 18. 4. 2020 v 22:36 odesílatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:

> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Fri, Apr 17, 2020 at 6:30 PM David G. Johnston
> > <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> >> I feel like writing them as:
> >> + (date, integer) -> date
> >> makes more sense as they are mainly sorted on the operator symbol as
> opposed to the left operand.
>
> > I thought about that, too, but I think the way Tom did it is better.
> > It's much more natural to see it using the syntax with which it will
> > actually be invoked.
>
> Just for the record, I experimented with putting back an "operator name"
> column, as attached. I think it could be argued either way whether this
> is an improvement or not.
>
> Some notes:
>
> * The column seems annoyingly wide, but the only way to make it narrower
> is to narrow or eliminate the column title, which could be confusing.
> Also, if there's not a fair amount of whitespace, it looks as if the
> initial name is part of the signature, which is *really* confusing,
> cf second screenshot. (I'm not sure why the vertical rule is rendered
> so much more weakly in this case, but it is.)
>
> * I also tried it with valign="middle" to center the operator name among
> its entries. This was *not* an improvement, it largely breaks the
> ability to see which entries belong to the name.
>

first variant looks better, because column with operator is wider.

Maybe it can look better if a content will be places to mid point. In left
upper corner it is less readable.

Regards

Pavel

> regards, tom lane
>
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Juan José Santamaría Flecha 2020-04-19 10:16:32 Re: PG compilation error with Visual Studio 2015/2017/2019
Previous Message David Rowley 2020-04-19 03:07:38 Re: Implementation DISTINCT for window aggregate function: SUM