Re: [COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring.

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring.
Date: 2016-02-12 16:35:58
Message-ID: CAFj8pRC-yhoqMz=tv3f478X_Eq_BU-hL+9wGaB26LsFThwF7=w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

2016-02-12 15:46 GMT+01:00 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:

>
>
> 2016-02-12 15:43 GMT+01:00 Robert Haas <robertmhaas(at)gmail(dot)com>:
>
>> On Fri, Feb 12, 2016 at 8:16 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
>> wrote:
>> >> That's very strange. It looks to me like you did exactly the right
>> >> thing. Can you provide any details on how it fails?
>> >
>> > Looks like some race conditions is there - but I didn't tested it deeper
>>
>> Well, OK, so I'm totally willing to work with you to help get this
>> straightened out, but I'm not really going to go download orafce and
>> debug it for you on company time. I'm fairly sure that won't win me
>> any large awards.
>>
>
> I'll do it - just need to finish some other. I hope so this night I'll
> know more.
>

In _PG_init I am creating new tranche by
RequestNamedLWLockTranche("orafce", 1);

Immediately when I try to use this lock

shmem_lock = sh_mem->shmem_lock = &(GetNamedLWLockTranche("orafce"))->lock;

I got a error

ERROR: XX000: requested tranche is not registered
LOCATION: GetNamedLWLockTranche, lwlock.c:602

Because the session initialization doesn't finish, then Orafce doesn't work

>
> Regards
>
> Pavel
>
>>
>> --
>> Robert Haas
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2016-02-12 17:09:04 pgsql: Fix whitespace
Previous Message Tom Lane 2016-02-12 16:20:22 pgsql: Add missing "static" qualifier.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-02-12 16:39:05 Re: GinPageIs* don't actually return a boolean
Previous Message Andres Freund 2016-02-12 16:35:26 Re: GinPageIs* don't actually return a boolean