Re: How to ensure that a stored function always returns TRUE or FALSE?

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Alexander Farber <alexander(dot)farber(at)gmail(dot)com>
Cc: pgsql-general <pgsql-general(at)postgresql(dot)org>
Subject: Re: How to ensure that a stored function always returns TRUE or FALSE?
Date: 2016-03-02 18:38:32
Message-ID: CAFj8pRByn0fGP0nK=0o0y-6qmuCPMVWkUwkOedTOtHXjjGqmwA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

Hi

2016-03-02 19:31 GMT+01:00 Alexander Farber <alexander(dot)farber(at)gmail(dot)com>:

> Thank you all for the valuable replies.
>
> I've also got suggestions to use IS NOT DISTINCT FROM or STRICT at
> http://stackoverflow.com/questions/35742865/how-to-ensure-that-a-stored-function-always-returns-true-or-false
>
>
> but the former has the edge case of NULL=NULL returning TRUE
> and with the latter I would have to be careful with the way I call my
> function -
> and I am worried I might forget it later and this is a security related...
>
> So I will probably use this function:
>
> CREATE OR REPLACE FUNCTION check_user(in_social integer,
> in_sid varchar(255),
> in_auth varchar(32))
> RETURNS boolean AS
> $func$
> SELECT CASE
> WHEN in_social IS NULL THEN FALSE
> WHEN in_sid IS NULL THEN FALSE
> WHEN in_auth IS NULL THEN FALSE
> ELSE (MD5('secret word' || in_social || in_sid) = in_auth)
> END;
>
> $func$ LANGUAGE sql IMMUTABLE;
>

this solution is ilustrative, but probably slower

I hope so function

REATE OR REPLACE FUNCTION check_user(in_social integer,
in_sid varchar(255),
in_auth varchar(32))
RETURNS boolean AS
$func$
SELECT COALESCE(MD5('secret word' || in_social || in_sid) =
in_auth, FALSE)
$func$ LANGUAGE sql IMMUTABLE;

should to return same result quckly.

Regards

Pavel

>
> Regards
> Alex
>
>
>
>
>
>

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Adrian Klaver 2016-03-02 18:41:44 Re: $user namespace with pg_dump?
Previous Message Alexander Farber 2016-03-02 18:31:11 Re: How to ensure that a stored function always returns TRUE or FALSE?