Re: Improving PL/Tcl's error context reports

Hi

čt 4. 7. 2024 v 21:42 odesílatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:

> I wrote:
> > Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> >> PLpgSQL uses more often function signature
> >> (2024-07-04 19:49:20) postgres=# select bx(0);
> >> ERROR: division by zero
> >> CONTEXT: PL/pgSQL function fx(integer) line 1 at RETURN
> >> PL/pgSQL function bx(integer) line 1 at RETURN
>
> > Oh that's a good idea! So let's use format_procedure(), same as
> > plpgsql does, to generate the final context line that currently
> > reads like
>
> > in PL/Tcl function "bogus"
>
> > Then, we could apply the "pull out just alphanumerics" rule to
> > the result of format_procedure() to generate the internal Tcl name.
> > That should greatly reduce the number of cases where we have duplicate
> > internal names we have to unique-ify.
>
> Here's a v2 that does it like that.
>

I like it.

- patching and compilation without any issue
- check world passed

I'll mark this as ready for commit

Regards

Pavel

> regards, tom lane
>
>