Re: proposal - function string_to_table

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: "movead(dot)li(at)highgo(dot)ca" <movead(dot)li(at)highgo(dot)ca>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal - function string_to_table
Date: 2020-07-05 11:30:29
Message-ID: CAFj8pRBjbeY=VDrMs=wHnEXWEmY8SvRRX7MDphyB4Kh+XkPZHA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

pá 5. 6. 2020 v 13:55 odesílatel Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
napsal:

> Hi
>
> čt 4. 6. 2020 v 11:49 odesílatel movead(dot)li(at)highgo(dot)ca <movead(dot)li(at)highgo(dot)ca>
> napsal:
>
>> +{ oid => '2228', descr => 'split delimited text',
>> + proname => 'string_to_table', prorows => '1000', proretset => 't',
>> + prorettype => 'text', proargtypes => 'text text',
>> + prosrc => 'text_to_table' },
>> +{ oid => '2282', descr => 'split delimited text with null string',
>> + proname => 'string_to_table', prorows => '1000', proretset => 't',
>> + prorettype => 'text', proargtypes => 'text text text',
>> + prosrc => 'text_to_table_null' },
>>
>> I go through the patch, and everything looks good to me. But I do not know
>> why it needs a 'text_to_table_null()', it's ok to put a 'text_to_table'
>> there, I think.
>>
>
> It is a convention in Postgres - every SQL unique signature has its own
> unique internal C function.
>
> I am sending a refreshed patch.
>

rebase

Regards

Pavel

> Regards
>
> Pavel
>
>
>
>
>>
>> ------------------------------
>> Regards,
>> Highgo Software (Canada/China/Pakistan)
>> URL : www.highgo.ca
>> EMAIL: mailto:movead(dot)li(at)highgo(dot)ca
>>
>

Attachment Content-Type Size
string_to_table-20200705.patch text/x-patch 13.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2020-07-05 11:35:33 Re: doc: vacuum full, fillfactor, and "extra space"
Previous Message Magnus Hagander 2020-07-05 11:28:38 Re: Parallell hashjoin sometimes ignores temp_tablespaces